Conversation
| { | ||
| "name": "web3-plugin-template", | ||
| "version": "1.0.0", | ||
| "version": "2.0.0", |
There was a problem hiding this comment.
I think. We do not need to change the version so much with these changes. It would be better to set 1.0.1 for ex.
There was a problem hiding this comment.
I also gree.
I am not sure. But maybe something like:
| "version": "2.0.0", | |
| "version": "1.1.0", |
There was a problem hiding this comment.
good point, I'll check to make sure that the peer dependency update breaks anything before we can commit to a version update
There was a problem hiding this comment.
FWIW I think 1.0.1 is a better choice for the version, per semantic versioning. Bumping the minor version (i.e. 1.1.0) would indicate that new non-breaking features were added. The third version number (patch) is the "fix" version and indicates that some existing feature was fixed. Ref: https://semver.org/
| { | ||
| "name": "web3-plugin-template", | ||
| "version": "1.0.0", | ||
| "version": "2.0.0", |
There was a problem hiding this comment.
I also gree.
I am not sure. But maybe something like:
| "version": "2.0.0", | |
| "version": "1.1.0", |
danforbes
left a comment
danforbes
left a comment
There was a problem hiding this comment.
Besides the discussion regarding the versioning this looks great. Thanks, Alex!
| { | ||
| "name": "web3-plugin-template", | ||
| "version": "1.0.0", | ||
| "version": "2.0.0", |
There was a problem hiding this comment.
FWIW I think 1.0.1 is a better choice for the version, per semantic versioning. Bumping the minor version (i.e. 1.1.0) would indicate that new non-breaking features were added. The third version number (patch) is the "fix" version and indicates that some existing feature was fixed. Ref: https://semver.org/
4 participants
currently when building a new plugin, you run into an error when compiling with version 4.0.3, updating the peer dependency fixes this. We also need to major bump the package as it will be a breaking change to older plugins that use older versions of web3 #10